FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is max

Summary

Classes Bugs Errors Missing Classes
73 15 0 0

org.nhindirect.gateway.smtp.AuditEvents

Bug Category Details Line Priority
org.nhindirect.gateway.smtp.AuditEvents.DEFAULT_HEADER_CONTEXT should be package protected MALICIOUS_CODE MS_PKGPROTECT 73 Medium
org.nhindirect.gateway.smtp.AuditEvents.MDN_HEADER_CONTEXT should be package protected MALICIOUS_CODE MS_PKGPROTECT 78 Medium
org.nhindirect.gateway.smtp.AuditEvents.MDN_RECEIVED_CONTEXT should be package protected MALICIOUS_CODE MS_PKGPROTECT 84 Medium

org.nhindirect.gateway.smtp.GatewayState

Bug Category Details Line Priority
org.nhindirect.gateway.smtp.GatewayState.INSTANCE should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available Medium

org.nhindirect.gateway.smtp.SmtpAgentFactory

Bug Category Details Line Priority
org.nhindirect.gateway.smtp.SmtpAgentFactory.INSTANCE should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available Medium

org.nhindirect.gateway.smtp.config.cert.impl.CertStoreUtils

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.nhindirect.gateway.smtp.config.cert.impl.CertStoreUtils.certFromData(KeyStoreProtectionManager, byte[]) STYLE REC_CATCH_EXCEPTION 105 Medium

org.nhindirect.gateway.smtp.dsn.impl.FailedDeliveryDSNCreator

Bug Category Details Line Priority

org.nhindirect.gateway.smtp.james.mailet.NHINDSecurityAndTrustMailet

Bug Category Details Line Priority
org.nhindirect.gateway.smtp.james.mailet.NHINDSecurityAndTrustMailet.init() might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 125 Medium
Redundant nullcheck of org.nhindirect.gateway.smtp.james.mailet.NHINDSecurityAndTrustMailet.agent, which is known to be non-null in org.nhindirect.gateway.smtp.james.mailet.NHINDSecurityAndTrustMailet.init() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 174 Medium

org.nhindirect.gateway.smtp.james.mailet.NotificationSuppressor

Bug Category Details Line Priority
Redundant nullcheck of txToTrack, which is known to be non-null in org.nhindirect.gateway.smtp.james.mailet.NotificationSuppressor.service(Mail) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 122 Medium

org.nhindirect.gateway.smtp.james.mailet.TimelyAndReliableLocalDelivery

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.nhindirect.gateway.smtp.james.mailet.TimelyAndReliableLocalDelivery.init() PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 125 High

org.nhindirect.gateway.streams.processor.STAPostProcessProcessor

Bug Category Details Line Priority
Nullcheck of txToTrack at line 165 of value previously dereferenced in org.nhindirect.gateway.streams.processor.STAPostProcessProcessor.suppressAndTrackNotifications(SMTPMailMessage) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 165 Medium

org.nhindirect.gateway.streams.processor.SmtpRemoteDeliveryProcessor

Bug Category Details Line Priority
org.nhindirect.gateway.streams.processor.SmtpRemoteDeliveryProcessor.remoteDeliver(SMTPMailMessage) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 171 High
Exception is caught when Exception is not thrown in org.nhindirect.gateway.streams.processor.SmtpRemoteDeliveryProcessor.getMailServers(SMTPMailMessage) STYLE REC_CATCH_EXCEPTION 248 Medium

org.nhindirect.gateway.util.MessageUtils

Bug Category Details Line Priority
Switch statement found in org.nhindirect.gateway.util.MessageUtils.trackMessage(Tx, boolean, TxService) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 216-220 Medium