PMD Results

The following document contains the results of PMD 6.8.0.

Files

org/nhindirect/gateway/GatewayConfiguration.java

Violation Priority Line
Avoid empty catch blocks 3 63
Useless parentheses. 4 89

org/nhindirect/gateway/smtp/DefaultSmtpAgent.java

Violation Priority Line
Useless parentheses. 4 367
Useless parentheses. 4 377
Avoid empty catch blocks 3 463468
Avoid empty catch blocks 3 513

org/nhindirect/gateway/smtp/GatewayState.java

Violation Priority Line
Useless parentheses. 4 216

org/nhindirect/gateway/smtp/SmtpAgent.java

Violation Priority Line
Unnecessary modifier 'public' on method 'processMessage': the method is declared in an interface type 3 55
Unnecessary modifier 'public' on method 'getAgent': the method is declared in an interface type 3 61
Unnecessary modifier 'public' on method 'getSmtpAgentSettings': the method is declared in an interface type 3 67

org/nhindirect/gateway/smtp/SmtpAgentFactory.java

Violation Priority Line
Useless parentheses. 4 370

org/nhindirect/gateway/smtp/config/cert/impl/CertStoreUtils.java

Violation Priority Line
Avoid empty catch blocks 3 105108
These nested if statements could be combined 3 125144

org/nhindirect/gateway/smtp/config/cert/impl/ConfigServiceRESTCertificateStore.java

Violation Priority Line
Avoid unused constructor parameters such as 'bootstrapStore'. 3 123
Avoid empty catch blocks 3 160163
Avoid empty catch blocks 3 186189
Avoid empty catch blocks 3 318323
Avoid empty catch blocks 3 364369
Avoid empty catch blocks 3 384389

org/nhindirect/gateway/smtp/dsn/DSNCreator.java

Violation Priority Line
Unnecessary modifier 'public' on method 'createDSNFailure': the method is declared in an interface type 3 48
Unnecessary modifier 'public' on method 'createDSNFailure': the method is declared in an interface type 3 60

org/nhindirect/gateway/smtp/dsn/impl/AbstractDSNCreator.java

Violation Priority Line
Avoid empty catch blocks 3 235238

org/nhindirect/gateway/smtp/james/mailet/DirectBounce.java

Violation Priority Line
Overriding method merely calls super 3 5053

org/nhindirect/gateway/smtp/james/mailet/NHINDSecurityAndTrustMailet.java

Violation Priority Line
Avoid empty catch blocks 3 125128
Avoid empty catch blocks 3 140143
Avoid empty try blocks 3 478480

org/nhindirect/gateway/smtp/james/mailet/TrackIncomingNotification.java

Violation Priority Line
Overriding method merely calls super 3 7780

org/nhindirect/gateway/streams/STAInput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'STA_INPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/STALastMileDeliveryOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'STA_LAST_MILE_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/STAOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'STA_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/STAPostProcessInput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'STA_POST_PROCESS_INPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/STAPostProcessOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'STA_POST_PROCESS_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/SmtpGatewayMessageInput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'SMTP_GATEWAY_MESSAGE_INPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/SmtpGatewayMessageOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'SMTP_GATEWAY_MESSAGE_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/SmtpGatewayMessageSource.java

Violation Priority Line
Useless parentheses. 4 45

org/nhindirect/gateway/streams/SmtpRemoteDeliveryInput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'SMTP_REMOTE_DELIVERY_MESSAGE_INPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/SmtpRemoteDeliveryOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'SMTP_REMOTE_DELIVERY_MESSAGE_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/SmtpRemoteDeliverySource.java

Violation Priority Line
Useless parentheses. 4 30

org/nhindirect/gateway/streams/XDRemoteDeliveryOutput.java

Violation Priority Line
Unnecessary modifiers 'public static final' on field 'XD_DELIVERY_MESSAGE_OUTPUT': the field is declared in an interface type 3 8

org/nhindirect/gateway/streams/processor/SmtpGatewayMessageProcessor.java

Violation Priority Line
Avoid empty if statements 3 7577

org/nhindirect/gateway/streams/processor/SmtpRemoteDeliveryProcessor.java

Violation Priority Line
Avoid empty catch blocks 3 171
Useless parentheses. 4 304